quacc icon indicating copy to clipboard operation
quacc copied to clipboard

Bug risk: Using `customize_funcs()` with Dask to update the parameters of a `@flow` or `@subflow`

Open Andrew-S-Rosen opened this issue 1 year ago • 0 comments

Details about the quacc environment

  • quacc version: 0.6.10+
  • Python version: 3.11

What is the issue?

https://github.com/Quantum-Accelerators/quacc/blob/fae639338d704489638574a7b7ef66d122f62594/src/quacc/wflow_tools/customizers.py#L100-L135

When calling customize_funcs() with the update_parameters keyword argument, the user can update the parameters of any @job, @flow, or @subflow. In most cases, this is a @job. However, if the object we are updating the parameters of is a @flow or @subflow, it won't be properly updated when using Dask unless we pass the decorator keyword argument to update_parameters which seems very easy to forget.

Andrew-S-Rosen avatar Mar 09 '24 07:03 Andrew-S-Rosen