Kartikey Singh

Results 21 comments of Kartikey Singh

Hey @cdrini, I would like to pick up this issue. Can I get assigned?

Hey @mekarpeles! I am very interested to work on this project and would definitely love to give it a try. How should I continue and go about it :)

@jimchamp Can you please review this PR :)

> If this is ready for review, press the "Ready for review" button. Is it ready for review? I said that there should only be yellow highlighting in [this comment](https://github.com/internetarchive/openlibrary/issues/8658#issuecomment-1872552273),...

@jimchamp I have made this PR ready for review. If you want me to revert the color of "removed" changes to yellow instead, Ill make a commit :+1:

@jimchamp Please review it this PR

@jimchamp I have implemented the required changes Before: ![Screenshot from 2024-02-22 21-49-30](https://github.com/internetarchive/openlibrary/assets/85943021/8aa161a6-58a0-4f4f-9c66-913b295e608d) After: ![Screenshot from 2024-02-22 21-49-43](https://github.com/internetarchive/openlibrary/assets/85943021/e062158d-d761-4f51-9ad0-0a36fc6e4fe7)

> I was expecting the HTML string, [here](https://github.com/internetarchive/openlibrary/blob/033117b3af38270b9fed9f49733c452e9f19d531/openlibrary/plugins/openlibrary/js/bulk-tagger/index.js#L6), to change. Did that not work? Yeh I thought of that and that works fine too. The only issue I had with...

@jimchamp Hey! I made the asked changes. It seems the screen recordings I am uploading are facing some encoding issues in firefox browser. After Updating the HTML string : https://github.com/internetarchive/openlibrary/assets/85943021/66981e5f-481e-4f2c-a8a7-389264f2d16c...

Hi there! I'd like to try working on this issue! Correct me if I am wrong, https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/site/banner.html, https://github.com/internetarchive/openlibrary/blob/master/openlibrary/templates/account/yrg_banner.html These seem like the concerning files here right?