zxlive Improving the style of tabs

Resolve #323

Jul 31 '24 16:07 RazinShaikh

I am satisfied with how it looks now. I would appreciate if people could check how it looks on their system. I have not tested on mac and linux, so it would be especially good to get feedback for those.

Jul 31 '24 21:07 RazinShaikh

Tagging @boldar99 @y-richie-y for mac

Jul 31 '24 21:07 RazinShaikh

For me, this is how it looks:

Aug 01 '24 08:08 boldar99

What's that horizontal line passing through the tabs?

Also the tabs are centered on Mac for some reason. This makes the lack of a left tab border look a bit strange.

Aug 01 '24 09:08 RazinShaikh

Can you also check if the effects of hovering on the tab and the close button look decent? And can you also try tabs with the system's dark mode?

Aug 01 '24 09:08 RazinShaikh

Hovering on X: And dark mode:

Aug 01 '24 09:08 boldar99

Okay so we need more changes to make it work for Mac. Perhaps we can do this in person sometime?

Aug 01 '24 09:08 RazinShaikh

@RazinShaikh @boldar99 Do you think you will still do this thing? I'm wondering whether it makes sense to keep this PR open.

Jan 30 '25 20:01 jvdwetering

I forgot about this PR. I don't have a mac so I can't try it. We can close it for now and then reopen it later at some point.

Jan 31 '25 14:01 RazinShaikh