tabmat icon indicating copy to clipboard operation
tabmat copied to clipboard

Reduce duplication in the Cython/C++ for sandwich and dot products.

Open ElizabethSantorellaQC opened this issue 5 years ago • 1 comments

Copied from https://github.com/Quantco/quantcore.glm/issues/221

There are several places where there's a lot of duplication: dense.pyx, dense_helpers-tmpl.cpp, categorical.pyx.

I'm not sure how feasible or reasonable it is to reduce this. It's going to be hard to do so without impacting performance.

ElizabethSantorellaQC avatar Jul 09 '20 13:07 ElizabethSantorellaQC

See #107 and #108

tbenthompson avatar Sep 29 '21 19:09 tbenthompson

Hi, are you accepting external contributions?

jjerphan avatar Apr 06 '23 11:04 jjerphan

@jjerphan Yes, we are happy to receive external contributions.

xhochy avatar Apr 06 '23 13:04 xhochy

Thanks for the information.

To me, it looks like the duplication in the files that are mentioned hardly can be removed without introducing extra complexity.

Yet, I think a few things might be simplified or improved in the code-base.

For now, I started with https://github.com/Quantco/tabmat/pull/245, a super minimalistic PR.

jjerphan avatar Apr 09 '23 16:04 jjerphan