lecture-python icon indicating copy to clipboard operation
lecture-python copied to clipboard

Minor Issues in *Asset Pricing with Incomplete Markets*

Open spspitze opened this issue 5 years ago • 3 comments

Hello again. Some minor typos in Asset Pricing with Incomplete Markets

  1. For the pessimists' beliefs, you copied the optimists' beliefs.

  2. For price_optimistic_beliefs() (and pessimistic) you specify tol=1e-16 in during inputs but the code compares to 1e-12. Also there seems to be no need to pre-assign p_old before the loop starts.

  3. I didn't quite get why the price of the asset had to be weakly greater than 1, as the code assumes. What's the intuition for this restriction?

Thanks as always.

spspitze avatar Jun 07 '20 21:06 spspitze

Thanks @spspitze, much appreciated. @Harveyt47, would you mind to take a look?

jstac avatar Jun 08 '20 02:06 jstac

Hi @jstac yep I'll have a look at it now.

Harveyt47 avatar Jun 08 '20 02:06 Harveyt47

@spspitze is right the pessimists transition matrix here should be [[2/3, 1/3], [2/3, 1/3]] I believe.

Also we do not use tol in both price_optimistic_beliefs() and price_pessimistic_beliefs(). I'll make a PR

Harveyt47 avatar Jun 08 '20 12:06 Harveyt47