lecture-python updating lake model mccall function to be consistent with mccall lecture

updating lake model mccall function to be consistent with mccall lecture

Open Harveyt47 opened this issue 4 years ago • 4 comments

Hi @jstac

I update the McCall function in the lake model to be consistent with the McCall lecture. The same changes I make in this notebook

I also add a random_state=seed in the markov chain simulation

May 05 '20 10:05 Harveyt47

🚀 Deployed on https://5eb1431c1ab4171097950e4a--practical-lalande-b89631.netlify.app

May 05 '20 10:05 github-actions[bot]

Thanks @Harveyt47 , that looks good to me.

May 08 '20 11:05 sayaikegawa

@shlff , are you able to review this pull request?

Does it look OK to you?

Dec 29 '20 07:12 jstac

Thanks @jstac . For the code in QE lectures, as you discussed with me before, we need to make a balance between its efficiency and readability.

I will give my comments on these changes in the following.

(Since this PR is quite old, I will briefly explain the changes in code before comments.)

Let's get started.

Dec 29 '20 21:12 shlff