lecture-python-intro icon indicating copy to clipboard operation
lecture-python-intro copied to clipboard

[ak2] Editorial Suggestions

Open Jiarui-ZH opened this issue 1 year ago • 2 comments

Comments by @pgrosser1

Overview

This is a topical lecture so maybe talk about what is going on right now with the economy and fiscal policies around the world

Potential lecture idea

  1. lecture on the constraints of optimisation
  2. Introduction lecture on demographics and how it interacts with the economy, especially on what might happen in the next 10 or 20 years

Content

  • [ ] #507
  • [x] Just before equation 31.3 add brackets saying that it is taking the first-order condition over the previous equation
  • [x] Before equation 31.8, Add a Wikipedia link or explaination on the Lagrangie condition OR even cut the entire Lagrangie idea out and substitute the constrain into the objective function (potentially creating a lecture on constraints of optimisation)
  • [ ] Starting from section 31.10.4, consider not having a graph for every single variable, only for those that will be mentioned. In general, it was difficult to understand the conclusion drawn from the graph and the graphs themselves are hard to read. There is too much information and not enough explanation, need a better connection between the figures and the explaination below the figures

Code

  • [x] change the usage of njit to jit and consider removing it if it result in no large run-time increase
  • [ ] For the code block in section 30.10.3 get rid of the class and change the entire code block to just functions
  • [ ] For the graphs, try to use object-oriented codes. Search for the usage of plt, which should be changed to object-orientated programming. Should use default figure size, highlight the code used for plotting, and let matplotlib pick the colours

Jiarui-ZH avatar Jun 29 '24 05:06 Jiarui-ZH

Thanks @Jiarui-ZH for these notes.

Sometimes it can be efficient to work on this while it is fresh. Would you be able to work on this today?

mmcky avatar Jun 30 '24 23:06 mmcky

@jstac Here is the runtime using njit Screenshot 2024-07-08 120558 and here is without using njit: Screenshot 2024-07-08 120653

the runtime is actually faster without njit so I will proceed to just removing it

Jiarui-ZH avatar Jul 08 '24 02:07 Jiarui-ZH