lecture-datascience.myst icon indicating copy to clipboard operation
lecture-datascience.myst copied to clipboard

Fix an issue in `merge` lecture

Open wupeifan opened this issue 3 years ago • 13 comments

This closes #198

wupeifan avatar Jan 04 '22 20:01 wupeifan

thanks @wupeifan I will need to look into the build failure this afternoon due to sphinx_exercise?

mmcky avatar Jan 05 '22 01:01 mmcky

@mmcky Yeah, I don't know what exactly happen there since I didn't touch that file in this PR and #197 . Both are failing for the same reason somehow. It shouldn't be because of the working_with_text lecture since the API of StatsCanada is now fixed.

wupeifan avatar Jan 05 '22 01:01 wupeifan

I am actually not able to replicate the environment.yml file on my mac. It is showing loads of pip failures due to llvm. Hmm ... tricky one.

@wupeifan seems like there is an issue with

https://pypi.org/project/Fiona/

mmcky avatar Jan 05 '22 02:01 mmcky

Yeah, that's possible. I think the maps lecture also uses fiona if I'm not mistaken...

wupeifan avatar Jan 05 '22 17:01 wupeifan

Just want to bump this up a bit -- is there a solution at this point?

wupeifan avatar Jan 12 '22 16:01 wupeifan

@wupeifan I am still having issues installing fiona both locally and on github actions. I think that install issue is preventing this from building. It can't find gdal it appears. Any ideas?

mmcky avatar Jan 13 '22 01:01 mmcky

It seems that it's currently failing on PyPI. NO ideas... maybe try conda?

wupeifan avatar Jan 13 '22 01:01 wupeifan

@wupeifan it has been failing for some time it appears on PyPI (last two versions).

I won't do this here but it would be good to move as many pip to conda as possible for the official environment given we are loading anaconda.

mmcky avatar Jan 13 '22 01:01 mmcky

I see. yeah, that makes sense.

wupeifan avatar Jan 13 '22 01:01 wupeifan

oh no it fails with the same error before.

Can I merge this one and the other PR that I have without compiling the new pages?

wupeifan avatar Jan 13 '22 02:01 wupeifan

I'll keep plugging away at this. It needs to be fixed as the new "publish" build wouldn't complete to publish the updates.

Also documented the issue: https://github.com/executablebooks/sphinx-exercise/issues/46

mmcky avatar Jan 13 '22 02:01 mmcky

@wupeifan looks like there is just one build issue with

  • [ ] working_with_text

building locally now to get a copy of the logs

LookupError: 
**********************************************************************
  Resource [93momw-1.4[0m not found.
  Please use the NLTK Downloader to obtain the resource:

  [31m>>> import nltk
  >>> nltk.download('omw-1.4')
  [0m
  For more information see: https://www.nltk.org/data.html

  Attempted to load [93mcorpora/omw-1.4[0m

  Searched in:
    - '/home/runner/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/share/nltk_data'
    - '/usr/share/miniconda3/envs/lecture-datascience/lib/nltk_data'
    - '/usr/share/nltk_data'
    - '/usr/local/share/nltk_data'
    - '/usr/lib/nltk_data'
    - '/usr/local/lib/nltk_data'
**********************************************************************

not sure why this isn't loading as omw-1.4 is listed if you click through to the nltk listing.

mmcky avatar Jan 13 '22 03:01 mmcky

@wupeifan I have run out of time today. The environment.yml for this project is really fragile. I get a lot of local errors when trying to build it on os x. The failure report still indicates there is an issue with nltk

https://github.com/QuantEcon/lecture-datascience.myst/suites/4919403137/artifacts/141871880

mmcky avatar Jan 13 '22 04:01 mmcky