lecture-datascience.myst icon indicating copy to clipboard operation
lecture-datascience.myst copied to clipboard

Should the static things be in the notebook repo?

Open jlperla opened this issue 3 years ago • 3 comments

Also, I notice there are the _panels_static and _static in https://github.com/QuantEcon/lecture-datascience.notebooks Just verifying that these are not accessed by relative paths from the notebooks - since that would obviously not work when things are downloaded.

I don't think they are supposed to be there, but I could be wrong. If so, we need to be 100% sure they are never accessed through relative paths anywhere.

jlperla avatar May 15 '21 03:05 jlperla

i think there's only one instance where we had a messy fix to a solution that is given out in the reshape lecture. chose to put it in _static instead of pd so users don't "accidentally" open it up prior to reading the question. nevertheless it's a full url. Don't spend too much time on this... if you get stuck, you will find our answer [here](https://github.com/QuantEcon/lecture-datascience.myst/raw/main/src/_static/reshape-ex1-ans.txt).

aadsouza avatar May 15 '21 04:05 aadsouza

Gotcha. I guess the only question is whether down the road we can keep those sorts of static assets in the HTML site which is better at serving up this sort of stuff.

But if you don't think there are any others then I will leave this until later and downgrade.

jlperla avatar May 15 '21 04:05 jlperla

in order to ensure that all the assets (images, dfs, etc.) are not being pulled from ds.qe.org as this could potentially cause conflicts when we release, more images are being added to the static repo following #118. they will all use full links so this exercise shouldn't create any issues if static is dropped from the nb repo.

aadsouza avatar May 28 '21 23:05 aadsouza