QuantEcon.py icon indicating copy to clipboard operation
QuantEcon.py copied to clipboard

BUG: Look like publish job isn't executing via conda_ci

Open mmcky opened this issue 2 years ago • 7 comments

https://github.com/QuantEcon/QuantEcon.py/runs/5862360679?check_suite_focus=true

mmcky avatar Apr 07 '22 04:04 mmcky

will wait for master to be passing all tests again and then re-trigger tag

mmcky avatar Apr 07 '22 04:04 mmcky

Looks OK

https://github.com/QuantEcon/QuantEcon.py/blob/97cebb4c5ceb720b801c8587f463ea6df2660992/.github/workflows/conda_ci.yml#L65

Not sure why this job is being skipped

mmcky avatar Apr 07 '22 04:04 mmcky

  • [x] manually uploaded package using flit https://pypi.org/project/quantecon/ and the updated README (thanks @Smit-create)

mmcky avatar Apr 07 '22 04:04 mmcky

Not sure why this job is being skipped

I guess because of this: https://github.com/QuantEcon/QuantEcon.py/blob/97cebb4c5ceb720b801c8587f463ea6df2660992/.github/workflows/conda_ci.yml#L69

Smit-create avatar Apr 07 '22 04:04 Smit-create

@Smit-create that line means it should run when a tag is pushed to master/main.

mmcky avatar Apr 07 '22 04:04 mmcky

I tagged a v0.5.3

https://github.com/QuantEcon/QuantEcon.py/releases/tag/v0.5.3

mmcky avatar Apr 07 '22 04:04 mmcky

How about changing that line to: if: github.event.ref_type == 'tag'

Smit-create avatar Apr 07 '22 04:04 Smit-create