Black Litterman PCM working on forcasted-data only

[jhonabreul]

Expected Behavior

The ROC is updated with real data, where using a forecasted value would make sense only for the last value.

Actual Behavior

The ReturnsSymbolData instance gets data (through the Add method) comming always from the Insight.Magnitude value, so the returns are based on forecasted data only.

Potential Solution

Update the return symbol data using asset's data, so the math is done based on the actual asset's ROC.

Splits/dividends should be accounted for by using scaled raw data to update the asset's ROC.

Reproducing the Problem

This was found while working on #7476

System Information

Windows 11

Checklist

• [x] I have completely filled out this template
• [x] I have confirmed that this issue exists on the current master branch
• [x] I have confirmed that this is not a duplicate issue by searching issues

• [x] I have provided detailed steps to reproduce the issue