PhastFT icon indicating copy to clipboard operation
PhastFT copied to clipboard

Implmentation of R2C FFT

Open smu160 opened this issue 1 year ago • 4 comments

@calebzulawski Draft for #23

smu160 avatar Apr 30 '24 02:04 smu160

Hi @calebzulawski,

We now have a working version of R2C FFT. This version is clearly sub-optimal as I made correctness the main priority. I'll measure and tune the implementation for now. In the interim, I recall you mentioned, inter alia, ideas about the public API and the use of traits.

I'm curious to hear your thoughts. Thank you!

Best, Saveliy

smu160 avatar May 29 '24 15:05 smu160

Looks good! I think starting with correctness is the way to go. Regarding traits, I think I will probably submit a PR in the future after this has been merged.

calebzulawski avatar May 29 '24 16:05 calebzulawski

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 99.53052% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.33%. Comparing base (7048416) to head (d099647).

Files with missing lines Patch % Lines
utilities/src/lib.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   99.16%   99.33%   +0.16%     
==========================================
  Files           8        9       +1     
  Lines         841     1053     +212     
==========================================
+ Hits          834     1046     +212     
  Misses          7        7              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar May 30 '24 15:05 codecov-commenter

Looks good! I think starting with correctness is the way to go. Regarding traits, I think I will probably submit a PR in the future after this has been merged.

Hi @calebzulawski,

I believe we're finally at a point where we can scrutinize the implementation, make necessary changes, and merge. Please feel free to point out any deficiencies and I can work on fixing them.

Thank you!!

smu160 avatar Jun 14 '24 18:06 smu160