QXlsx icon indicating copy to clipboard operation
QXlsx copied to clipboard

CMake support

Open skypjack opened this issue 5 years ago • 7 comments

Hi there,

I'd like to include this library in a cmake based project. It would be great if QXlsx had also a CMakeLists.txt file to compile it as a target library rather than including directly its sources. Is there any plan to add it or would you accept a PR in this sense otherwise? Also, if you have any advise to make it work differently, please drop a line here. It would be appreciated.

skypjack avatar Jan 17 '20 09:01 skypjack

Dear @skypjack

There are no plans to apply cmake for versions of QXlsx that use Qt5.

But the new Qt6 technology vision recommends using cmake as the main build method. Qt6 is expected to be released by the end of 2020, and cmake will be required to use QXlsx in Qt6.

I will register this issue as an enhancement. Thank you for your report.

j2doll avatar Jan 18 '20 02:01 j2doll

Nvm. I can wait. In the meantime I'm using cmake's external project to download, build and add this project when needed. Thanks for answering. :+1:

skypjack avatar Jan 18 '20 09:01 skypjack

Hi, I just pushed a new branch with a CMakeLists. You'll find it here : https://github.com/QtExcel/QXlsx/pull/72

laurennlam avatar Mar 30 '20 09:03 laurennlam

@j2doll Please merge #106

KangLin avatar Sep 02 '20 03:09 KangLin

Dear @KangLin

Sorry for the late reply. I'm currently working on a commercial project where internet use is restricted. Internet is only available on weekends. The environment without internet is more serious than Corona.

  • I merged to dev96 branch.
    • If there is no big problem, I will merge the dev96 branch into the master branch, later..

j2doll avatar Sep 05 '20 09:09 j2doll

Hi, why did you delete CMakeLists.txt? In c8ca4f5bba5ae8a16b5bbdbaba3ba6df094949fa

DarthGandalf avatar Sep 16 '21 20:09 DarthGandalf

Nvm, I got confused, it's now in QXlsx/ subdirectory

DarthGandalf avatar Sep 16 '21 21:09 DarthGandalf