RedisLess icon indicating copy to clipboard operation
RedisLess copied to clipboard

Int parse error

Open rahulghangas opened this issue 3 years ago • 4 comments

Return relevant error if parsing of integer argument for (incr, incr_by, decr, decr_by) fails

rahulghangas avatar May 29 '21 14:05 rahulghangas

Hey @rahulghangas - thank you for this PR. Can you take a look at the tests? It seems that one is failing. Thank you 🙏

evoxmusic avatar May 30 '21 17:05 evoxmusic

Ah yep, that's the test that I added. I believe it might be related to a deeper bug since the error returned has characters missing, I will debug it when I get back to my machine later.

rahulghangas avatar May 31 '21 05:05 rahulghangas

@evoxmusic please review again

rahulghangas avatar Jun 04 '21 09:06 rahulghangas

Sure, I'll this weekend

evoxmusic avatar Jun 04 '21 10:06 evoxmusic