color icon indicating copy to clipboard operation
color copied to clipboard

Invalid value input is not handled properly

Open headwindz opened this issue 3 years ago • 2 comments

How to reproduce:

  1. Open Sandbox
  2. Check the console output

Current behavior

  • For invalid rgb input (E.g. "rgb(277,0,0)"), r is rounded to the nearest valid value 255 and a value is returned.
  • For invalid hex input (E.g. "#p10000"), an exception is thrown.

Expected behavior

Exceptions are expected to be thrown for all invalid inputs (i.e. for input that can't be turned into an equivalent color).

Extra info

Probablly related to this code: https://github.com/Qix-/color-string/blob/4daceef89391f28eba415d043bbd1163c8f19a8c/index.js#L128

headwindz avatar Jan 13 '22 16:01 headwindz

I agree though this is a breaking change. It'd have to wait for v5 unfortunately.

Qix- avatar Apr 05 '22 08:04 Qix-

Any plan for v5 😃

headwindz avatar May 31 '22 03:05 headwindz