rustworkx icon indicating copy to clipboard operation
rustworkx copied to clipboard

Migrate `steiner_tree()` and `metric_closure()` to rustworkx-core

Open mtreinish opened this issue 2 years ago • 4 comments

What is the expected enhancement?

The metric_closure() and steiner_tree() functions available at: https://github.com/Qiskit/rustworkx/blob/main/src/steiner_tree.rs should be straightforward to port to rustworkx-core and rework as generic for any petgraph graph and then update the python functions to call the inner rustworkx-core function. This will then expose this functionality to any rust users that might want this functionality.

mtreinish avatar Jan 03 '23 17:01 mtreinish

I noticed that metric_closure uses all_pairs_dijkstra_shortest_paths so that function needs to be moved as well.

tapanih avatar Jan 30 '23 16:01 tapanih

Can I be assigned to this?

yoshida-ryuhei avatar Jun 07 '23 05:06 yoshida-ryuhei

Sure thing, I've assigned the issue to you

mtreinish avatar Jun 08 '23 01:06 mtreinish

Thank you. I am going to implement this patch!

yoshida-ryuhei avatar Jun 08 '23 02:06 yoshida-ryuhei

This was implemented in https://github.com/Qiskit/rustworkx/pull/1103

mtreinish avatar Mar 22 '24 13:03 mtreinish