rustworkx icon indicating copy to clipboard operation
rustworkx copied to clipboard

Move more connected components functions to retworkx-core

Open enavarro51 opened this issue 2 years ago • 6 comments

What is the expected enhancement?

#595 is in the process of moving connected_components and number_connected_components from retworkx/src/connectivity/conn_components.rs to retworkx-core/src/connectivity/conn_components.rs.

There are a number of other connected component related functions in retworkx/src/connectivity/mod.rs, such as strongly_connected_components, is_connected, and node_connected_component, that could also be moved over to retworkx-core/src/connectivity. The function in mod.rs would then just call the retworkx-core version, similar to what's done with connected_components.

enavarro51 avatar May 02 '22 18:05 enavarro51

Hi @enavarro51, Is this issue still relevant? I would like to help as much as I can.

kris524 avatar Jul 02 '22 01:07 kris524

Sure. Any of the functions in retworkx.src.connectivity.mod.rs that are not already in retworkx.retworkx-core.src.connectivity could be moved in a way similar to the way connected_components was done. Let me know if you have any questions about it.

enavarro51 avatar Jul 02 '22 19:07 enavarro51

Hey @enavarro51 I would like to work on this. I have read and also got the slightest idea of what needs to be done. Also, I'm unable to find the retworkx-core folder.

acharyasourav avatar Sep 07 '22 08:09 acharyasourav

Hi @SUGARXUST thanks for reaching out. If you want you can have a look at my MR and help with testing and adding more stuff

kris524 avatar Sep 07 '22 09:09 kris524

Sure I would like to help @kris524 please mention the request so that I can see what's going on and what can be done by me.

acharyasourav avatar Sep 07 '22 09:09 acharyasourav

https://github.com/Qiskit/rustworkx/pull/638

kris524 avatar Sep 07 '22 09:09 kris524