rustworkx icon indicating copy to clipboard operation
rustworkx copied to clipboard

token_swapper to accept generic map and to return its swaps as (G::NodeId, G::NodeId)

Open gluonhiggs opened this issue 6 months ago • 3 comments

Resolve #1437 and #1438 The modification is straightforward with some docs changes. My first commit is to resolve #1437. My 2nd commit is for #1438

gluonhiggs avatar Jun 09 '25 06:06 gluonhiggs

Pull Request Test Coverage Report for Build 15589798928

Details

  • 49 of 52 (94.23%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 95.27%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rustworkx-core/src/token_swapper.rs 30 33 90.91%
<!-- Total: 49 52
Totals Coverage Status
Change from base Build 15448809297: -0.01%
Covered Lines: 18973
Relevant Lines: 19915

💛 - Coveralls

coveralls avatar Jun 09 '25 07:06 coveralls

Not a maintainer here. My understanding of https://github.com/Qiskit/rustworkx/blob/main/CONTRIBUTING.md is that you should add tests for this new functionality

I ran the existing tests and thought these were enough. Let me check again.

gluonhiggs avatar Jun 11 '25 11:06 gluonhiggs

I have added new tests and modified the token_swapper rust core, wrapper, stub. Thank you for reminding me @1ucian0

gluonhiggs avatar Jun 11 '25 16:06 gluonhiggs