qiskit icon indicating copy to clipboard operation
qiskit copied to clipboard

Force tag fetching in Azure docs build

Open jakelishman opened this issue 1 year ago • 3 comments

Summary

Azure are changing the default of the checkout action to no longer fetch tags. Our docs process uses reno, which does inspect tags. In theory, our pipeline should be grandfathered into the old behaviour, and reno shouldn't explode if the tags aren't available (it should just silently miscategorise things, which doesn't matter since this isn't the production build), but this proactively protects us against either of those things changing.

See: https://learn.microsoft.com/en-gb/azure/devops/release-notes/2022/sprint-209-update?tabs=yaml#do-not-sync-tags-when-fetching-a-git-repository

Details and comments

This might fail to build right now - I'm not certain if the Azure backend has rolled out this extra item to the YAML schema for the Qiskit org yet.

jakelishman avatar Sep 21 '22 15:09 jakelishman

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

qiskit-bot avatar Sep 21 '22 15:09 qiskit-bot

Yep, Azure hasn't rolled out the noTags item for us yet. I'll check in again in a couple of weeks.

jakelishman avatar Sep 21 '22 15:09 jakelishman

Pull Request Test Coverage Report for Build 4309659292

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.343%

Totals Coverage Status
Change from base Build 4309626206: 0.0%
Covered Lines: 67530
Relevant Lines: 79128

💛 - Coveralls

coveralls avatar Sep 21 '22 15:09 coveralls

Not available yet.

jakelishman avatar Oct 18 '22 22:10 jakelishman

I'm just going to close this: I feel lied to by the Azure changelog docs.

jakelishman avatar Mar 02 '23 01:03 jakelishman

Ha, it turns out that Azure silently edited their release notes at some point to change the name of the new option, and to change its default. We may not need this PR now since Azure appear to be committing to keep this as the default behaviour, but here's what it might look like if we choose to do it.

Oh, and now this PR is broken because the branch got force-pushed while the PR was closed. Oh well, never mind.

jakelishman avatar Mar 02 '23 01:03 jakelishman