qiskit
qiskit copied to clipboard
Qiskit
QFI with the primitives
Summary
This PR adds a newQFI class using Linear Comb. of Unitaries with the primitives.
Details and comments
- [x] LinCombQFI
- [ ] BlockDiagQFI?
- [ ] DiagQFI?
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the the following people are requested to review this:
- @Qiskit/terra-core
- @manoelmarques
- @woodsp-ibm
Pull Request Test Coverage Report for Build 3370620088
- 275 of 286 (96.15%) changed or added relevant lines in 13 files are covered.
- 32 unchanged lines in 5 files lost coverage.
- Overall coverage decreased (-0.002%) to 84.455%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| qiskit/algorithms/gradients/utils.py | 45 | 46 | 97.83% |
| qiskit/algorithms/gradients/lin_comb_estimator_gradient.py | 36 | 39 | 92.31% |
| qiskit/algorithms/gradients/lin_comb_qfi.py | 121 | 124 | 97.58% |
| qiskit/algorithms/gradients/base_qfi.py | 39 | 43 | 90.7% |
| <!-- | Total: | 275 | 286 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| qiskit/quantum_info/operators/symplectic/sparse_pauli_op.py | 1 | 90.67% |
| src/optimize_1q_gates.rs | 1 | 95.16% |
| qiskit/extensions/quantum_initializer/squ.py | 2 | 79.78% |
| src/sabre_swap/mod.rs | 2 | 95.05% |
| src/results/marginalization.rs | 26 | 73.56% |
| <!-- | Total: | 32 |
| Totals | |
|---|---|
| Change from base Build 3370143536: | -0.002% |
| Covered Lines: | 62412 |
| Relevant Lines: | 73900 |
💛 - Coveralls
@dlasecki @woodsp-ibm Thank you so much for reviewing the PR! I fixed the codes based on the comments. I also changed to use options instead of run_options. I think it's ready now.