Use Sabre by default for optimization levels 1 and 2

[mtreinish]

Summary

This commit updates the preset pass manager construction to use the SabreLayout and SabreSwap passes by default for optimization level 1 and level 2. With the recently merged #7977 the performance of the sabre swap pass has improved significantly enough to be considered for use by default with optimization levels 1 and 2. While for small numbers of target device qubits (< 30) the SabreLayout/SabreSwap pass doesn't quite match the runtime performance of DenseLayout/StochasticSwap it typically has better runtime performance for larger target devices. Additionally, the runtime performance of Sabre should also improve further after #8388 is finished. However, the output quality from the sabre passes is typically better resulting in fewer swap gates being inserted. With the combination of better quality and comparable runtime performance it makes sense to use sabre as the default for optimization levels 1 and 2. For optimization level 0 stochastic swap is still used there because we want to continue to leverage TrivialLayout for that level and to get the full quality advantages SabreSwap and SabreLayout should be used together.

Details and comments

[qiskit-bot]

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

• @Qiskit/terra-core

[mtreinish]

For some data backing this change up, I ran these benchmarks: https://github.com/Qiskit/red-queen/tree/main/red_queen/games/mapping/benchmarks/misc#readme to compare SabreLayout/SabreSwap with DenseLayout/StochasticSwap which yielded the following plots:

For CX gate count post routing:

For runtime performance of layout and routing:

[nonhermitian]

This is nice.

[kdk]

💯 , can you add the scripts to generate these plots as an example somewhere in red-queen?

[coveralls]

Pull Request Test Coverage Report for Build 3127193931

• 41 of 46 (89.13%) changed or added relevant lines in 4 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.1%) to 84.427%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/transpiler/passes/routing/sabre_swap.py	7	8	87.5%
src/sabre_swap/neighbor_table.rs	30	34	88.24%
<!--	Total:	41	46

Files with Coverage Reduction	New Missed Lines	%
qiskit/transpiler/passes/layout/dense_layout.py	2	94.9%
<!--	Total:	2

Totals
Change from base Build 3126106140:	0.1%
Covered Lines:	59606
Relevant Lines:	70601

---

💛 - Coveralls

[gushuli]

Thank you for your efforts in redeveloping Sabre in Rust! I really appreciate it~

Gushu

[mtreinish]

Since #8388 is ready for review now I reran the benchmark script used above with #8388 applied to get a feel for the relative performance after it merges:

With #8388 it looks like Sabre is faster most of the time and definitely scales better for larger inputs and target devices.

I also added a graph showing the output circuit depth after running SabreLayout and SabreSwap on the input circuits:

The interesting thing there is that circuit depth seems to increase slightly when using sabre but the overall swap count decreases.

[kdk]

For the 0.22 release, there is a goal of having the preset pass managers support control flow, so before we can merge this we should have a plan or PR for integrating control flow support in sabre, similar to https://github.com/Qiskit/qiskit-terra/pull/8565 .

[jakelishman]

@kdk: or we can cheat, and use Sabre by default if there's no control flow, and whatever we've got if there is.

[kdk]

Following some discussion with the team, the current plan is to start with Dense+StochasticSwap as default for circuits with control flow (as part of #8630 and #8418 ), and implement control flow handling with SabreSwap/SabreLayout post 0.22 release.