qiskit
qiskit copied to clipboard
Qiskit
Consective 1q param gates
Summary
Two or more Pauli rotation gates (Rx, Ry, Rz) that contain the parameters will be combined together.
Details and comments
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the the following people are requested to review this:
- @Qiskit/terra-core
Pull Request Test Coverage Report for Build 2838137906
- 20 of 26 (76.92%) changed or added relevant lines in 3 files are covered.
- 3 unchanged lines in 1 file lost coverage.
- Overall coverage decreased (-0.006%) to 84.039%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| qiskit/circuit/parameterexpression.py | 0 | 6 | 0.0% |
| <!-- | Total: | 20 | 26 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| qiskit/pulse/library/waveform.py | 3 | 89.36% |
| <!-- | Total: | 3 |
| Totals | |
|---|---|
| Change from base Build 2835258003: | -0.006% |
| Covered Lines: | 56328 |
| Relevant Lines: | 67026 |
💛 - Coveralls
That's a great extension! Does this also collect cases where other single qubit gates are in between Pauli rotations, like RY(a) H RY(b)? And can we extend this to cover other parameterized single qubit gates like P (and ideally also U)?
I am wondering if the CommutativeCancellation pass also tries to do something similar?
