qiskit
qiskit copied to clipboard
Qiskit
Deprecate PauliTable
Summary
- Deprecate
PauliTable - Deprecate
StabilizerTable.pauli - Make
StabilizerTablea standalone (i.e. independent from PauliTable)
Details and comments
TODO
- [x] Add Releasenote
Pull Request Test Coverage Report for Build 1519291394
- 151 of 167 (90.42%) changed or added relevant lines in 3 files are covered.
- 3 unchanged lines in 2 files lost coverage.
- Overall coverage increased (+0.01%) to 82.868%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| qiskit/quantum_info/operators/symplectic/stabilizer_table.py | 144 | 160 | 90.0% |
| <!-- | Total: | 151 | 167 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| qiskit/quantum_info/operators/symplectic/pauli_table.py | 1 | 89.35% |
| qiskit/quantum_info/operators/symplectic/stabilizer_table.py | 2 | 88.4% |
| <!-- | Total: | 3 |
| Totals | |
|---|---|
| Change from base Build 1517139552: | 0.01% |
| Covered Lines: | 50271 |
| Relevant Lines: | 60664 |
💛 - Coveralls
@chriseclectic: I'd recommend against having non-trivial @property getter methods; if x.phase constructs a new array on every access, it's very very easy to introduce big performance issues without noticing. If you're going to have data transformations on the class, it's probably best to put them in a "proper" function (so don't use @property), so it's clear at the call site that it's an expensive call - calling x.phase() multiple times looks wrong, which makes it safer from a performance perspective.
I'll modify this PR after https://github.com/Qiskit/qiskit-terra/pull/7269. (So, don't merge this)