qiskit
qiskit copied to clipboard
Qiskit
Add shape to the *Pub constructors
Summary
This PR adds a shape argument to the *Pub constructors.
Details and comments
This is done in a backward-compatible way. However, implementations of primitives that happen to look directly at SamplerPub.parameter_values.shape instead of Samplerub.shape will return the wrong shape. I propose that we go find-and-replace all such occurrences in IBM implementations prior to release of 2.1.
Motivation
TODO: write this down. It has to do with new-style mitigation.
One or more of the following people are relevant to this code:
@Qiskit/terra-core@ajavadia@levbishop@t-imamichi
Pull Request Test Coverage Report for Build 15256368166
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 12 of 12 (100.0%) changed or added relevant lines in 1 file are covered.
- 7 unchanged lines in 3 files lost coverage.
- Overall coverage increased (+0.002%) to 88.336%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| crates/circuit/src/symbol_expr.rs | 1 | 75.21% |
| crates/cext/src/circuit.rs | 2 | 81.16% |
| crates/qasm2/src/lex.rs | 4 | 92.23% |
| <!-- | Total: | 7 |
| Totals | |
|---|---|
| Change from base Build 15188294429: | 0.002% |
| Covered Lines: | 78485 |
| Relevant Lines: | 88848 |
💛 - Coveralls
This was originally intended for 2.1, but staled and wasn't touched at all within the 2.2 window. Shall we close it?
