Qiskit
Fix CPhaseGate parameter name mismatch in API docs
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Cryoris@Qiskit/terra-core@ajavadia
Pull Request Test Coverage Report for Build 11583269541
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 32 unchanged lines in 5 files lost coverage.
- Overall coverage decreased (-0.03%) to 88.651%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| crates/accelerate/src/unitary_synthesis.rs | 1 | 92.2% |
| qiskit/transpiler/passes/synthesis/unitary_synthesis.py | 2 | 58.05% |
| crates/qasm2/src/lex.rs | 5 | 91.48% |
| qiskit/synthesis/two_qubit/xx_decompose/decomposer.py | 6 | 90.77% |
| crates/qasm2/src/parse.rs | 18 | 95.77% |
| <!-- | Total: | 32 |
| Totals | |
|---|---|
| Change from base Build 11582517625: | -0.03% |
| Covered Lines: | 75315 |
| Relevant Lines: | 84957 |
💛 - Coveralls
yes i will check this out. i had a question about notation i asked on the issue. it seems like changing the notation to theta rather than parameter to lambda is correct?
i realized that the notation should be changed since the parameters are inferred from Controlled Gate
@jakelishman later today or early am tomorrow. i can take a second to look for any more incorrect notation.
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Cryoris@Qiskit/terra-core@ajavadia
Thanks, Cameron! It looks like there is a merge conflict in qiskit/circuit/library/standard_gates/u1.py
