qiskit icon indicating copy to clipboard operation
qiskit copied to clipboard

Update dag_drawer Documentation to include DAGDependency on Allowed Types

Open azhar-ikhtiarudin opened this issue 1 year ago • 3 comments

Summary

This PR fixes #13021 by updating the dag_drawer documentation to include DAGDependency on allowed types

Details and comments

initial:

Args:
    dag (DAGCircuit): The dag to draw.

updated:

Args:
      dag (DAGCircuit or DAGDependency): The dag to draw.

azhar-ikhtiarudin avatar Sep 27 '24 16:09 azhar-ikhtiarudin

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @enavarro51
  • @Qiskit/terra-core

qiskit-bot avatar Sep 27 '24 16:09 qiskit-bot

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 27 '24 16:09 CLAassistant

Pull Request Test Coverage Report for Build 11074493538

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.02%) to 88.848%

Files with Coverage Reduction New Missed Lines %
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.26%
crates/qasm2/src/lex.rs 3 93.48%
qiskit/synthesis/two_qubit/xx_decompose/decomposer.py 6 90.91%
<!-- Total: 11
Totals Coverage Status
Change from base Build 11069637765: 0.02%
Covered Lines: 74016
Relevant Lines: 83306

💛 - Coveralls

coveralls avatar Sep 30 '24 20:09 coveralls

Hi @nonhermitian @1ucian0 @ElePT

I hope you’re all doing well. It’s been more than three weeks since this PR has been awaiting review. All checks have passed, and it’s ready for merging once the code owner review is complete. Just a gentle reminder, and please let me know if you need any further information.

Thank you for your time and help!

azhar-ikhtiarudin avatar Oct 24 '24 02:10 azhar-ikhtiarudin