qiskit
qiskit copied to clipboard
Qiskit
Port synth_cnot_phase_aam to Rust
Pull Request Test Coverage Report for Build 18744206691
Details
- 254 of 259 (98.07%) changed or added relevant lines in 4 files are covered.
- 26 unchanged lines in 5 files lost coverage.
- Overall coverage increased (+0.002%) to 88.217%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| crates/synthesis/src/linear_phase/cnot_phase_synth.rs | 232 | 237 | 97.89% |
| <!-- | Total: | 254 | 259 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| crates/circuit/src/parameter/parameter_expression.rs | 1 | 81.99% |
| crates/qasm2/src/expr.rs | 1 | 93.82% |
| crates/qasm2/src/lex.rs | 2 | 91.77% |
| crates/circuit/src/parameter/symbol_expr.rs | 10 | 72.78% |
| crates/qasm2/src/parse.rs | 12 | 96.15% |
| <!-- | Total: | 26 |
| Totals | |
|---|---|
| Change from base Build 18725764531: | 0.002% |
| Covered Lines: | 93619 |
| Relevant Lines: | 106124 |
💛 - Coveralls
Thanks for working on this! I have not yet looked closely at the PR (and it's marked as work-in-progress), but I would like to suggest to set up a proper directory structure from the beginning. You have added a new linear_phase directory (which is great), and now you want to add mod.rs to that (and not modify files in linear directory). Please feel free to ask any additional questions.
Thanks Noted !!!
On Sun, 11 Aug, 2024, 6:58 pm Alexander Ivrii, @.***> wrote:
Thanks for working on this! I have not yet looked closely at the PR (and it's marked as work-in-progress), but I would like to suggest to set up a proper directory structure from the beginning. You have added a new linear_phase directory (which is great), and now you want to add mod.rs to that (and not modify files in linear directory). Please feel free to ask any additional questions.
— Reply to this email directly, view it on GitHub https://github.com/Qiskit/qiskit/pull/12937#issuecomment-2282761545, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANBTUUIEN2PKYVENG4DGVHDZQ5RGDAVCNFSM6AAAAABMJKPVUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSG43DCNJUGU . You are receiving this because you authored the thread.Message ID: @.***>
I see that you have some lint issues, and would like to suggest to use cargo clippy.
In addition, could you compare the performance of your rust code with the previous python code?
you should then compile it in the release mode: python setup.py build_rust --inplace --release
@ShellyGarion , I want to publicly apologize for the delay in getting this PR on track. Qiskit Challenge and QGSS happened to be extra interesting this time. and, dealing with 'cuQuantum' is no less interesting either.
@HuangJunye , The credit goes to Junye for any good that came out of this PR, because he gave me his precious time and motivated me to learn rust in QAMP. Thanks Junye Huang for all your time. :)
@alexanderivrii , Thanks for your previous comments and guidance, I have tried to maintain a balance between performance, simplicity and code-readability, please let me know if something needs to change.
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the following people are relevant to this code:
@Qiskit/terra-core@kevinhartman@mtreinish
