qiskit
qiskit copied to clipboard
Qiskit
introduce new plugin infra for circuit drawer
Summary
adding an infra to support adding custom circuit drawers
Closes https://github.com/Qiskit/qiskit/issues/11900
Details and comments
this change mainly introduces plugin.py file which will act as a skeleton for newer circuit drawer plugins and support of these plugins to run (change in circuit_visualization.py)
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the the following people are requested to review this:
- @enavarro51
@Qiskit/terra-core
Pull Request Test Coverage Report for Build 8437168870
Details
- 21 of 27 (77.78%) changed or added relevant lines in 3 files are covered.
- 5 unchanged lines in 1 file lost coverage.
- Overall coverage increased (+0.005%) to 89.333%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| qiskit/visualization/circuit/circuit_visualization.py | 5 | 7 | 71.43% |
| qiskit/visualization/circuit/plugin.py | 15 | 19 | 78.95% |
| <!-- | Total: | 21 | 27 |
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| crates/qasm2/src/lex.rs | 5 | 92.37% |
| <!-- | Total: | 5 |
| Totals | |
|---|---|
| Change from base Build 8423693946: | 0.005% |
| Covered Lines: | 59854 |
| Relevant Lines: | 67001 |
💛 - Coveralls
Thank you for opening a new pull request.
Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.
While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.
One or more of the the following people are requested to review this:
- @enavarro51
@Qiskit/terra-core
In general, PRs on features requests have a lower priority than bug fixes. Additionally, the freeze for API changing PRs is in two days. The team is focused towards that right now, so hard to tell.
As I noticed this is your first PR in the project, just a heads-up: Qiskit's time-to-merge time is not great but we are always trying to improve it. Thanks for your patience.
is there some kind of an ETA or means to progress it somehow. it would be great getting a feedback regarding the estimation time of reviewing.
Thanks for understanding.