qiskit icon indicating copy to clipboard operation
qiskit copied to clipboard

pending deprecations from 0.21

Open 1ucian0 opened this issue 1 year ago • 4 comments

There are some pending deprecations that can be deprecations in 1.1 (to be removed in 2.0).

0.21: Released in June 30, 2022 (wrt last minor release, 19 month old)
 - qiskit/transpiler/passes/scheduling/alap.py:30 (__init__) - PENDING
 - qiskit/transpiler/passes/scheduling/asap.py:36 (__init__) - PENDING
 - qiskit/transpiler/passes/scheduling/dynamical_decoupling.py:107 (__init__) - PENDING
 - qiskit/transpiler/passes/scheduling/alignments/align_measures.py:93 (__init__) - PENDING

The deprecated classes are:

  • ALAPSchedule
  • ASAPSchedule
  • DynamicalDecoupling
  • AlignMeasures

1ucian0 avatar Feb 27 '24 15:02 1ucian0

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

qiskit-bot avatar Feb 27 '24 15:02 qiskit-bot

Aside from the test failures here, I'm also relatively sure that these classes are used in some documentation examples - I think I've looked at doing these deprecations before.

jakelishman avatar Feb 28 '24 00:02 jakelishman

Pull Request Test Coverage Report for Build 8124574074

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 89.294%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 5 91.18%
<!-- Total: 6
Totals Coverage Status
Change from base Build 8104544265: 0.01%
Covered Lines: 59120
Relevant Lines: 66208

💛 - Coveralls

coveralls avatar Mar 01 '24 09:03 coveralls

Thanks! Tests fixed.

I also searched for the deprecated classes in documentation/docs/transpile and I got no hits. I can raise an issue in Qiskit/documentation if you feel strongly that something can break there.

1ucian0 avatar Mar 01 '24 10:03 1ucian0