qiskit.org icon indicating copy to clipboard operation
qiskit.org copied to clipboard

As a member of the development team, I want my contributions to be as good as possible, so I deliver the most of the value without compromising code maintainability.

Open delapuente opened this issue 3 years ago • 1 comments

This user story encompasses the efforts of checking code quality automatically. Code reviews should focus on providing valuable human-insight, such as readability and understandability, and delegate on automatic tools as much as possible.

delapuente avatar Sep 20 '20 16:09 delapuente

@eddybrando, I think we have tools like linters in our CI/CD that close out this issue?

pandasa123 avatar Jun 21 '22 19:06 pandasa123

I'd imagine the code of conduct covers the valuable human insight portion already too?

jackoconnordev avatar Jul 28 '23 15:07 jackoconnordev

@y4izus we can probably close this, right?

eddybrando avatar Jul 31 '23 10:07 eddybrando

I think that we can close this.

In general, we already have a CI/CD setup as @pandasa123 pointed out, and a code of conduct in place as @jackoconnordev pointed out.

CC: @y4izus

eddybrando avatar Jan 03 '24 07:01 eddybrando