qiskit.org icon indicating copy to clipboard operation
qiskit.org copied to clipboard

Setup visual regression testing

Open eddybrando opened this issue 4 years ago • 0 comments

We've had some style regressions that are quite hard to catch in our code reviews. And as the codebase grows, the more likely are these kind of bugs to appear as the result of hard to track side-effects, since we reuse variables and style definitions across the project.

In order to avoid this, we're currently spending a lot of time in code reviews checking pages and components individually, and only so we can catch these regressions, as exemplified in #1679.

As discussed offline, we should try and automate as many checks as possible to catch errors early and seamlessly, improving our code quality and our development experience, allowing us to invest our code reviewing time in other tasks that cannot be automated 🤖 .

As a starting point, we can take a look at jest-image-snapshot and also review this list with other suggestions.

eddybrando avatar Apr 20 '21 13:04 eddybrando