qiskit.org
qiskit.org copied to clipboard
Qiskit
[General UI] The icon in the landing CTA should be an arrow
Steps to reproduce the problem
- Navigate to qiskit.org
- Notice the icon of the "Get started" CTA
What is the current behavior?
The icon is the one indicating a navigation outside qiskit.org.
What is the expected behavior?
Since qiskit.org/documentation/install.html is under qiskit.org, the icon should be an arrow.
There are three projects under qiskit.org, one is this Nuxt site, living under qiskit.org/. The other two, the documentation and the textbook are static sites and do not belong to this project. Trying to navigate to them using the Vue.js router breaks the navigation. We need to use the native navigation provided by the a HTML element.
Our AppLink component, encapsulates this behavior. It has mechanisms to determine when using a or nuxt-link components. If passed an absolute URL, the component immediately assumes we want to navigate outside the domain. This is leveraged in PR #1227 but introduces a regression making the component to display the incorrect icon.
Perhaps we should make the Nuxt project aware about the static sites and let it know those navigations to /documentation and /textbook should rely on the native HTML navigation regardless if we want it to open in the same or a different tab.
To add to this, I would prefer if both links to documentation and textbook open in the same tab instead of opening a new tab. To our users, they won't know its a different site with a different structure. Particularly on the textbook, opening new tabs could result in several tabs open unknowingly with our given navigation.
So, to summarise, @JRussellHuffman proposes (please correct me if I'm wrong):
- Opening the "Get started" link on the same tab
- Displaying the corresponding icon for that action
@lerongil should we agree on this implementation?
Everyone else, any other opinions?
That is correct. Our users won't know there are multiple domains working together, so I'm in favor of not opening a new tab (and thus having the corresponding icon).
Per offline conversations, all the links that contains qiskit.org should have the arrow.
