qiskit-serverless icon indicating copy to clipboard operation
qiskit-serverless copied to clipboard

Add dependency parsing grammar for gateway allowlist

Open psschwei opened this issue 1 year ago • 5 comments
trafficstars

Summary

Part of #369

This PR adds the dependency specification grammar from PEP 508 (https://peps.python.org/pep-0508/) to use when validating dependencies via the allowlist.

As a temporary measure, it also simplifies the check to only consider the dependency and not a specific version. As such, it has dropped the test for related to dependency version.

Future work should be done to convert the allowlist file from JSON to the standard requirements.txt format, which would allow for easier version checking.

Details and comments

psschwei avatar Aug 15 '24 14:08 psschwei

The gateway pod seems to be restarting in the k8s test, not sure why yet

psschwei avatar Aug 15 '24 15:08 psschwei

huh, it's getting hit with an OOMKilled error... that doesn't happen locally, could just be an issue in the action...

psschwei avatar Aug 15 '24 16:08 psschwei

ok, bumping the resource limits on the gateway fixed the issue

psschwei avatar Aug 15 '24 16:08 psschwei

Good to know because we had the same problem with the scheduler Wed 😂

Tansito avatar Aug 16 '24 13:08 Tansito

Add it on-hold tag until we can work together on this 😄

Tansito avatar Aug 16 '24 14:08 Tansito