Shot branching tests are unreliable on macOS

[wshanks]

Informations

• Qiskit Aer version: 0.14.1
• Python version: 3.8-3.12
• Operating system: macOS x86_64

What is the current behavior?

Some of the shot branching tests are failing for macOS, for example here. The tests get run as part of the conda build and two of them failed in three of the five Python versions run:

• test.terra.backends.test_runtime_parameterization.TestRuntimeParameterization.test_dynamic_circuit_with_shot_branching_1___statevector____CPU__
• test.terra.backends.aer_simulator.test_shot_branching.TestShotBranching.test_shot_branching_reset_moving_qubits_1___statevector____CPU__
• test.terra.backends.aer_simulator.test_shot_branching.TestShotBranching.test_shot_branching_reset_nondeterministic_1___statevector____CPU__

The CI run with the failures is here (also a different test failed here).

Steps to reproduce the problem

Run the tests (a few times?) under macOS x86_64.

What is the expected behavior?

All tests pass reliably.

Suggested solutions

[doichanj]

I'm recognizing this issue is caused by PR #2098 but I have not figure out the source of the issue yet