qiskit-aer icon indicating copy to clipboard operation
qiskit-aer copied to clipboard

"approximation" argument of Estimator is poorly named

Open kevinsung opened this issue 1 year ago • 2 comments

What is the expected behavior?

It's somewhat confusing that setting approximation=True is necessary to get the exact expectation value. For example, consider this sentence from the documentation:

If None and approximation is True, it calculates the exact expectation values.

I suggest renaming the argument to simulate_sampling_error or just simulate_error.

kevinsung avatar May 25 '23 12:05 kevinsung

Hi @hhorii this PR is ready for review.

athanzxyt avatar Jun 02 '23 17:06 athanzxyt

Yes. This requires some DeprecationWarning. I'll redesign overall with options (with flexible dataclass) align with qiskit-ibm-runtime.

ikkoham avatar Jun 06 '23 02:06 ikkoham