qiskit-addon-cutting icon indicating copy to clipboard operation
qiskit-addon-cutting copied to clipboard

Remove cutQC first pass

Open caleb-johnson opened this issue 1 year ago • 3 comments

Fixes #519

Remaining action items

  • [ ] Release note
  • [x] Remove utils/conversion.py and utils/metrics.py
  • [x] Remove --omit="circuit_knitting/cutting/cutqc/**/*,circuit_knitting/utils/conversion.py,circuit_knitting/utils/metrics.py" from coverage command in tox.ini
  • [x] Remove cutqc and metrics from addopts line in pyproject.toml, and anything else added temporarily as part of #527
  • [x] grep for remaining references to cplex (e.g. in the README)
  • [x] Remove the platform: linux/amd64 line from compose.yaml and change the Docker CI workflow to run on macos-latest so it tests the Docker image on ARM

caleb-johnson avatar May 22 '24 19:05 caleb-johnson

Pull Request Test Coverage Report for Build 9225128307

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+4.5%) to 100.0%

Totals Coverage Status
Change from base Build 9184284091: 4.5%
Covered Lines: 2375
Relevant Lines: 2375

💛 - Coveralls

coveralls avatar May 22 '24 19:05 coveralls

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI due to references to missing package

caleb-johnson avatar May 22 '24 19:05 caleb-johnson

@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI

It's because we don't use Sphinx's "nitpicky" mode, so classes that don't exist don't raise errors. I tried experimenting with this mode in #196 but it was a disaster.

garrison avatar May 22 '24 19:05 garrison

OK, maybe my idea to use Docker on macOS was half baked ;) since Docker is apparently not installed on the macOS image that github actions uses.

We can always make this change in a future PR if we really want to test Docker on M series Mac.

garrison avatar May 22 '24 20:05 garrison

  • Overall coverage increased (+4.5%) to 100.0%

We should throw a party :tada: :rocket:

garrison avatar May 23 '24 20:05 garrison