qiskit-addon-cutting
qiskit-addon-cutting copied to clipboard
Remove cutQC first pass
Fixes #519
Remaining action items
- [ ] Release note
- [x] Remove
utils/conversion.pyandutils/metrics.py - [x] Remove
--omit="circuit_knitting/cutting/cutqc/**/*,circuit_knitting/utils/conversion.py,circuit_knitting/utils/metrics.py"from coverage command intox.ini - [x] Remove
cutqcandmetricsfromaddoptsline inpyproject.toml, and anything else added temporarily as part of #527 - [x] grep for remaining references to cplex (e.g. in the README)
- [x] Remove the
platform: linux/amd64line fromcompose.yamland change the Docker CI workflow to run onmacos-latestso it tests the Docker image on ARM
Pull Request Test Coverage Report for Build 9225128307
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+4.5%) to 100.0%
| Totals | |
|---|---|
| Change from base Build 9184284091: | 4.5% |
| Covered Lines: | 2375 |
| Relevant Lines: | 2375 |
💛 - Coveralls
@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI due to references to missing package
@garrison why are our release notes not causing problems with sphinx? There are references to cutqc that don't exist anymore. I was assuming our sphinx build would fail in CI
It's because we don't use Sphinx's "nitpicky" mode, so classes that don't exist don't raise errors. I tried experimenting with this mode in #196 but it was a disaster.
OK, maybe my idea to use Docker on macOS was half baked ;) since Docker is apparently not installed on the macOS image that github actions uses.
We can always make this change in a future PR if we really want to test Docker on M series Mac.
- Overall coverage increased (+4.5%) to 100.0%
We should throw a party :tada: :rocket: