documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Kjf/noise learning

Open kaelynj opened this issue 1 year ago • 3 comments
trafficstars

Closes #1830

kaelynj avatar Aug 16 '24 19:08 kaelynj

One or more of the following people are relevant to this code:

  • @abbycross
  • @javabster
  • @lerongil

qiskit-bot avatar Aug 16 '24 19:08 qiskit-bot

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I want to add a link to the NoiseLearnerOptions api ref page, but will need to do that later once the runtime 0.28 api refs are built.

kaelynj avatar Aug 16 '24 19:08 kaelynj

Overall this looks good, just 2 things:

  • number of qubits in the code examples is very small, any way we can scale it up a bit?
  • doc is missing a "next steps" section at the bottom

javabster avatar Aug 20 '24 14:08 javabster

  • number of qubits in the code examples is very small, any way we can scale it up a bit?

If this is what we want, then I suggest looking for the largest ring in the backend that we are using, and placing entangling gates on each pair. This would result in one "many qubits" noise-learning experiment, as opposed to many "few qubit" experiments with the GHZ circuits that would take forever.

For example, on ibm_bangkok one could run the following:

ring = [0, 1, 4, 7, 10, 12, 15, 18, 21, 23, 24, 25, 22, 19, 16, 14, 11, 8, 5, 3]
layer = list(zip(ring[::2], ring[1::2]))

circuit = QuantumCircuit(27)
for pair in layer:
    circuit.cx(*pair)

noise_learner.run(circuit)

SamFerracin avatar Aug 20 '24 15:08 SamFerracin

Overall this looks good, just 2 things:

* number of qubits in the code examples is very small, any way we can scale it up a bit?

* doc is missing a "next steps" section at the bottom

Just finished addressing these! This PR is ready for another review.

kaelynj avatar Aug 23 '24 16:08 kaelynj

Finished this last round of edits. @javabster or @jyu00 do either of you have any more comments/suggestions?

kaelynj avatar Aug 29 '24 13:08 kaelynj