zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

Improve exception safety with smart pointers

Open elfring opened this issue 7 years ago • 2 comments

Would you like to wrap any pointer data members with the template class “std::unique_ptr”?

elfring avatar Jan 25 '18 14:01 elfring

Thanks elfring,

But we prefer to use raw pointer than any smart pointers, and believe following good code style we can control it with no extra overhead.

Only once we used shared_ptr for Partition since we need its sharing of ownership and reference counting.

CatKang avatar Jan 26 '18 02:01 CatKang

Did you notice that the implementation of the class “ZPMetaServer” is unsafe so far because of mentioned preferences?

elfring avatar Jan 26 '18 09:01 elfring