phptrace icon indicating copy to clipboard operation
phptrace copied to clipboard

Bad reported version.

Open remicollet opened this issue 8 years ago • 8 comments

$ php -n -d extension=trace-1.0.0/extension/modules/trace.so --re trace
Extension [ <persistent> extension #15 trace version 0.6.0-beta ] {

Seems definitively better to use standardized macro name (PHP_TRACE_VERSION) which is checked during the upload on pecl, and avoid such common mistake...

remicollet avatar Jan 19 '17 14:01 remicollet

There are three version in phptrace, main version and cli version are 1.0.0 and the ext version is 0.6.0. since the last version extension are not so stable, so it`s version just 0.6.0

silkcutKs avatar Jan 20 '17 04:01 silkcutKs

So terribly confusing for users

  • If you have 3 projects with 3 versions, then release separately and manage them separately in 3 repo.
  • Single repo, single project, single version.

remicollet avatar Jan 20 '17 06:01 remicollet

And so "stability" should be the lowest one, so "beta"

More, as this is released on PECL, the package released there should use the ext. version (as PECL is an "extension" repo)

remicollet avatar Jan 20 '17 06:01 remicollet

@monque remicollet have some suggest for the version

silkcutKs avatar Jan 20 '17 06:01 silkcutKs

Thanks for @remicollet advice, we'll keep only one version. e7fdd9cfea044a7473a10b0f55140249dc9d972f

monque avatar Mar 04 '17 17:03 monque

Seems definitively better to use standardized macro name (PHP_TRACE_VERSION) which is checked during the upload on pecl, and avoid such common mistake...

What's the checking mechanism during the upload?

Compare macro PHP_TRACE_VERSION with package.xml literally?

monque avatar Mar 04 '17 17:03 monque

Compare macro PHP_TRACE_VERSION with package.xml literally?

Yes. http://git.php.net/?p=web/pecl.git;a=blob;f=public_html/release-upload.php;h=681f14a47a5ba39f103bbc9b826847e072255f91;hb=HEAD#l108

remicollet avatar Mar 04 '17 17:03 remicollet

http://git.php.net/?p=web/pecl.git;a=blob;f=public_html/release-upload.php;h=681f14a47a5ba39f103bbc9b826847e072255f91;hb=HEAD#l102

It seems that this script will never check extension/php_trace.h due to the sub folder...

monque avatar Mar 05 '17 03:03 monque