Quicksql icon indicating copy to clipboard operation
Quicksql copied to clipboard

Published 20 hours ago • verified publisher icon Qihoo360

[BUG] testParseSingleBdNameAndTableNameWithError in tableNameCollectorTest is not as expected

Open IcePigZDB opened this issue 2 years ago • 0 comments

Versions

eg: 99b77fbac300b739d6383832273544bb09aa8396

Describe the bug

Current error parameter in validateTableName can not throw exception in case of A.A.A, see testParseSingleBdNameAndTableNameWithError and testParseSingleBdNameAndTableNameWithError2.

To Reproduce

Steps to reproduce the behavior:

  1. Go to TableNameCollectorTest
  2. Dubug on testParseSingleBdNameAndTableNameWithError
  3. You will find no exception throw, I think it's not as expected.

Expected behavior

Throw exception.

Actual behavior

No exception. Because there is no exception, so it pass these two tests luckily.

Additional context

截图_选择区域_20220711121158

  • I open an pr to fix it #279.

IcePigZDB avatar Jul 11 '22 04:07 IcePigZDB