Quicksql icon indicating copy to clipboard operation
Quicksql copied to clipboard

fix: update error parameter from 3 to 2 in tableNameCollector in case of `A.A.A`

Open IcePigZDB opened this issue 2 years ago • 0 comments

I'm submitting a...

  • [x] Bug fix
  • [ ] Feature
  • [ ] Refactoring
  • [ ] Added tests
  • [ ] Documentation
  • [ ] Other (Please describe in detail here)

Checklist

  • [x] Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bug fix commit message is prefixed "fix:"
  • [x] Tests for the changes have been added

Description

  • close #280

Current error parameter in validateTableName can not throw exception in case of A.A.A, see testParseSingleBdNameAndTableNameWithError and testParseSingleBdNameAndTableNameWithError2. So I change it to 2 from 3.

Does this PR introduce a breaking change?

  • [ ] Yes
  • [x] No

IcePigZDB avatar Jul 11 '22 03:07 IcePigZDB