Qichen Zhu

Results 50 comments of Qichen Zhu

Edited by **proposal-police**: This proposal was **edited** at 2024-12-04 00:24:13 UTC. ## Proposal ### Please re-state the problem that we are trying to solve in this issue. After opening a...

@rayane-djouah Thanks for bringing up this question! There’s a conflict between maintaining the visible content position https://github.com/facebook/react-native/blob/8aac234ce2483dd08d9f8e8481e53855519ab887/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/MaintainVisibleScrollPositionHelper.java#L132 https://github.com/Expensify/App/blob/9184118f78259bd3aa812be51d96987425bb54ef/src/components/FlatList/index.tsx#L129 and scrolling to the bottom. https://github.com/Expensify/App/blob/9184118f78259bd3aa812be51d96987425bb54ef/src/pages/home/report/ReportActionsList.tsx#L436 On Android the former wins, while...

## Proposal [Updated](https://github.com/Expensify/App/issues/52878#issuecomment-2515801152) @rayane-djouah I found that `isTheFirstReportActionIsLinked` could mean two things: 1. there are no newer actions, or 2. newer actions are still loading. In the second case, setting...

@truph01 thanks for the proposal. I'll review it today.

@vishalPwc thanks for the [comment](https://github.com/Expensify/App/issues/63355#issuecomment-2936749360). How does that issue relate to this? In that issue, the group chat is empty, while in this issue, the chat includes an expense.

@truph01 any idea why `notificationPreference` is an empty string? The type says it can't be, so we probably never considered this case. Should we fix the type definition as well?...

@truph01 thanks for the info. Unfortunately, neither the main nor the alternative solutions work for me. Can you try switching between chats and refreshing the page to see if the...

@truph01 I tested the alternative again but it still doesn't work for me. Could you check if you have any other local changes not in the proposal? https://github.com/user-attachments/assets/2804d45c-4870-4788-8b82-a058dd9cac70

@truph01 I tested with a new account that only has a few chats, and the group chat still disappears, as shown in the video. I saw you split a manual...

@truph01's [proposal](https://github.com/Expensify/App/issues/63355#issuecomment-2936329388) and [comment](https://github.com/Expensify/App/issues/63355#issuecomment-2949783145) make sense to me. We need both backend and frontend fixes. #### Backend Could `CreateDistanceRequest` return `notificationPreference: "always"`, like `SplitBill` already does? | API | Response...