crawlergo icon indicating copy to clipboard operation
crawlergo copied to clipboard

Published 20 hours ago • verified publisher icon Qianlitp

[Code Review] 函数中的无效参数

Open PIGfaces opened this issue 2 years ago • 0 comments

Discussed in https://github.com/Qianlitp/crawlergo/discussions/107

Originally posted by PIGfaces June 28, 2022 https://github.com/Qianlitp/crawlergo/blob/dbf70647a44bbfbdaeec98791f90c2497d781708/pkg/engine/tab.go#L264-L270

函数 RunWithTimeOut 中的 ctx 参数并没使用到，可以把它去掉吗，真正用到 ctx 是上层的函数调用，上层的 context 超时时间为 TabRunTimeout 到了这一层变成了 DomContentLoadedTimeout 这是出于什么原因呀

PIGfaces avatar Jul 05 '22 09:07 PIGfaces