QiangF

Results 203 comments of QiangF

The other place that need this ordering is in focus_by_click, I have fixed it. Probably fixing these two places is enough. I am not sure if there are any cases...

I don't know how to make that test. Maybe put in the definition of bring_to_front like this: @expose_command() def bring_to_front(self): if self.get_wm_type() != "desktop": if self.qtile.current_window != self: self.focus(warp =...

Sorry I don't know how to do that.

> I appreciate the fixes, but I really think we need some tests to enforce this behavior. Otherwise, we're likely to break it with some future refactoring, since all this...

> Unfortunately, that doesn't work very well in practice. People move on, get busy, etc. and we lose the reason for the ordering. An automated test is the best way...

Just a comment to make this issue alive.

@tych0 Can you give a direction on how to make this test? ie. check if a window is in focus before bring to front.

> Seems like the file move was unintentional? I am sorry. Fixed now.

Sorry the commits just messed up. Time to learn more git.

@elParaguayo The issue is confirmed by an expert. https://github.com/aravinda0/qtile-bonsai/issues/23 A better way to reproduce the issue using built-in layout: 1. use MonadTall layout by default 2. open 2 window, and...