LeetHub icon indicating copy to clipboard operation
LeetHub copied to clipboard

Published 20 hours ago • verified publisher icon QasimWani

Update gfg.js

Open ASahu16 opened this issue 2 years ago • 7 comments

Fix https://github.com/QasimWani/LeetHub/issues/307

ASahu16 avatar Jul 17 '22 16:07 ASahu16

thanks for taking charge of this. looking into it

QasimWani avatar Jul 19 '22 04:07 QasimWani

sir please do changes so that it can work now....you are the only hope @ASahu16

kshitijmishra27 avatar Jul 23 '22 08:07 kshitijmishra27

sir please do changes so that it can work now....you are the only hope @ASahu16

@kshitijmishra27 you mean this fix is not working? If yes, please add more info so I can replicate the issue.

ASahu16 avatar Jul 23 '22 09:07 ASahu16

@QasimWani PTAL.

ASahu16 avatar Jul 25 '22 06:07 ASahu16

i think submit button ID has also been changed . Infact it is completely removed and given a class name of problems_submit_button__6QoNQ

heysujal avatar Aug 27 '22 19:08 heysujal

i think submit button ID has also been changed . Infact it is completely removed and given a class name of problems_submit_button__6QoNQ

The whole site has been migrated on Next.js. In this PR submit button is captured using the document.evaluate() based upon the text content("submit"), previously it was captured using document.getElementById('run') method call. You can check the diff. Hope it helps! :v:

ASahu16 avatar Aug 28 '22 08:08 ASahu16

Hi Qasim, can this change be merged please if it's all good? I need it to have GFG codes on the repo. This is an awesome extension. Hopefully, this issue gets resolved soon.

ankitkashyap12 avatar Aug 29 '22 08:08 ankitkashyap12

while this works functionally, there's no message showing that it works. On leetcode.com, we have a spinner showing the state of merge. Works for now, but additional changes needed for better UX.

Sure we'll try to add that too.

ASahu16 avatar Oct 09 '22 12:10 ASahu16