LeetHub icon indicating copy to clipboard operation
LeetHub copied to clipboard

Unnecessary commits for notes

Open SysSn13 opened this issue 3 years ago • 8 comments

LeetHub is uploading notes for all the problems even if it is empty. It is not a good idea to commit an empty file for every submission. To Reproduce Steps to reproduce the behavior:

  • regular submission for any problem

Expected behavior Commit the notes only when something is written by the user or there are some new changes in the notes.

SysSn13 avatar Sep 27 '21 06:09 SysSn13

what do you mean notes? is it ReadMe? If so, i'm unable to reproduce it. it has been working fine so far. Please list exact procedure (and screenshots) to reproduce. Was this a one-off thing? Perhaps wait a little longer before switching/closing tabs? Have you tried reloading and resubmitting again?

QasimWani avatar Oct 04 '21 04:10 QasimWani

See this. Well It's not updated on the chrome web-store yet.

SysSn13 avatar Oct 04 '21 07:10 SysSn13

Also having this issue Screen Shot 2022-01-10 at 3 24 55 PM

amirali-shfz avatar Jan 10 '22 20:01 amirali-shfz

Yeah I'm patching it up by temporarily removing the notes feature. That should solve this problem for now. Apologies for the buggy release.

QasimWani avatar Jan 11 '22 09:01 QasimWani

Hey, has the feature been removed yet? After I made the submission today, empty Notes.md files were committed and I had to delete them on my own.

sarthak1905 avatar Jan 18 '22 06:01 sarthak1905

There's a duplicate thread https://github.com/QasimWani/LeetHub/issues/195 Still not implemented. Waiting for the release! :)

NikitaShkaruba avatar Feb 16 '22 03:02 NikitaShkaruba

Please implement this feature on chrome extensions store. The notes.md file is always committing unnecessarily. Plz remove this.

VinayLodhi1712 avatar Feb 02 '24 15:02 VinayLodhi1712