ezquake-source icon indicating copy to clipboard operation
ezquake-source copied to clipboard

BUG: can't compile linux binary Fedora

Open timofeika opened this issue 1 year ago • 8 comments

In main page in description how to build linux binary for Fedora, not enough one package in dependencies list, in build-linux.sh it's exist, "minizip-devel".

timofeika avatar Sep 09 '24 16:09 timofeika

I'm not well versed with Fedora, but looks like it's packaged, https://packages.fedoraproject.org/pkgs/minizip/minizip-devel/

Alternatively as you seem to be building from a git checkout, you could build a static binary instead which will not rely on distribution dependencies. Make sure that cmake, ninja, autoconf automake, libtool and pkg-config are installed and run:

./bootstrap.sh
cmake --preset static
cmake --build build-static --config Release

It will take a couple of minutes on a modern machine as it builds all the deps. It's newly introduced so hopefully it works as great on Fedora as elsewhere.

dsvensson avatar Sep 09 '24 17:09 dsvensson

...and an even easier solution if you don't have any code changes is downloading an AppImage:

https://builds.quakeworld.nu/ezquake/releases/latest/linux/x86_64/ https://builds.quakeworld.nu/ezquake/snapshots/latest/linux/x86_64/

dsvensson avatar Sep 09 '24 18:09 dsvensson

Issue is "Fix README - add minizip-devel for Fedora build section". :-D

VVD avatar Sep 09 '24 18:09 VVD

@VVD No, not it, it's listed here, https://github.com/QW-Group/ezquake-source/blob/master/build-linux.sh#L13

perhaps Fedora has different repos and not all enabled by default.

dsvensson avatar Sep 09 '24 18:09 dsvensson

Something with the @timofeika's Fedora installation at least. I just tried it in Docker here,

docker run  --rm -it -v `pwd`:/src fedora bash

I had to run yum update and installing git before running ./build-linux.sh but after that it worked as expected.

dsvensson avatar Sep 09 '24 19:09 dsvensson

@VVD No, not it, it's listed here, https://github.com/QW-Group/ezquake-source/blob/master/build-linux.sh#L13

perhaps Fedora has different repos and not all enabled by default.

Yes. We discuss this in Discord before @timofeika create this issue. Check README: https://github.com/QW-Group/ezquake-source/blob/master/README.md?plain=1#L154 Script have minizip-devel, but README - no.

VVD avatar Sep 09 '24 19:09 VVD

Indeed, @VVD is right :P

timofeika avatar Sep 09 '24 20:09 timofeika

Yes that whole readme needs some shaping up. I'm doing it iteratively as PRs merge. It's very outdated. macOS part has been updated, and there's a PR that contains update for the Windows build. Linux/BSD build coming up next.

dsvensson avatar Sep 09 '24 20:09 dsvensson