ezquake-source icon indicating copy to clipboard operation
ezquake-source copied to clipboard

BUG: amd - leaks from flashblend when gl_outline is enabled

Open ciscon opened this issue 1 year ago • 4 comments

When both gl_flashblend and gl_outline are enabled there are leaks (large streaks appear in various directions) from flashblend elements, this can be seen most easily during pregame when everyone is glowing and one has gl_rl_globe enabled. It's been this way for a long while with amd gpus on both linux and windows.

ezquake007

ciscon avatar Dec 28 '23 23:12 ciscon

The fix for this newer bug (https://gitlab.freedesktop.org/mesa/mesa/-/issues/10353) also appears to remedy this problem. Will test once merged into mesa upstream.

ciscon avatar Jan 17 '24 18:01 ciscon

This is now fixed in mesa main.

ciscon avatar Jan 26 '24 20:01 ciscon

it appears this still happens with mesa main with particular settings.

ciscon avatar Feb 16 '24 17:02 ciscon

it would appear to be this call to glm_drawsequentialbatch, if we skip it everything appears to render properly except flashblend explosions: glm_sprite3d.c: 178 else if (batch->allSameNumber && batch->numVertices[0] == 18 && GL_Supported(R_SUPPORT_PRIMITIVERESTART)) { 179 GLM_DrawSequentialBatch(batch, indexes_start_flashblend, INDEXES_MAX_FLASHBLEND); 180 }

moving renderer.Draw3DSprites(); before GLM_DrawAliasModelBatches(); also fixes the problem, but this has the side effect of rendering the alias models outside of the flashblend bubbles.

ciscon avatar Feb 16 '24 17:02 ciscon