ezquake-source icon indicating copy to clipboard operation
ezquake-source copied to clipboard

BUG: Cross compilation results in wrong executable name

Open fzwoch opened this issue 2 years ago • 1 comments

Currently Makefile assumes it is doing a host compile always:

    ifndef CPU
        CPU := $(shell uname -m | sed -e s/i.86/i386/ -e s/amd64/x86_64/ -e s/sun4u/sparc64/ -e s/arm.*/arm/ -e s/sa110/arm/ -e s/alpha/axp/)
    endif
    ifndef SYS
        SYS := $(shell uname -s)
    endif

So cross compile will result in the wrong info for these two variables. Can be observed in current CI on macOS where the arm64 target is being build on an intel Mac:

Run .github/workflows/scripts/homebrew.sh build-arm64
[..]
[LD] ezquake-darwin-x86_64

fzwoch avatar Aug 30 '23 12:08 fzwoch

For context, only cosmetic issue, the script calling the executable is also incorrectly generated, so the correct executable launches no matter what name it has. Looks bad though, and adds confusion.

dsvensson avatar Oct 17 '23 16:10 dsvensson