ezquake-source icon indicating copy to clipboard operation
ezquake-source copied to clipboard

Follow up of PR691

Open tcsabina opened this issue 3 years ago • 5 comments

tcsabina avatar Oct 08 '22 18:10 tcsabina

Look like use before initialization.

VVD avatar Oct 09 '22 03:10 VVD

@ciscon @dsvensson , how does this PR look like? Does it tackle all the issues from PR 691?

@VVD , where exactly?

tcsabina avatar Oct 13 '22 21:10 tcsabina

@tcsabina looks good to me

ciscon avatar Oct 13 '22 21:10 ciscon

Particle trails no longer render when fog is enabled, haven't checked other particle effects so maybe more affected. Haven't had time to check why, and it's slightly outside of my skill set. Maybe it's just some shader ordering or something. At the same time it would suck if the fog stuff bitrotted unmerged as it looks great otherwise.

dsvensson avatar Oct 14 '22 06:10 dsvensson

The texture commit can be merged separately if you put this on hold, it works great.

dsvensson avatar Oct 14 '22 06:10 dsvensson